ENH: Add type annotations for image API (FileBasedImage and DataobjImage) #1178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 92.37% // Head: 92.38% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1178 +/- ##
==========================================
+ Coverage 92.37% 92.38% +0.01%
==========================================
Files 97 97
Lines 12267 12284 +17
Branches 2526 2526
==========================================
+ Hits 11332 11349 +17
Misses 614 614
Partials 321 321
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
effigies
force-pushed
the
type/primary_image_api
branch
from
2859287 to
cb85b94
Compare
effigies
force-pushed
the
type/primary_image_api
branch
from
cb85b94 to
05a0b2f
Compare
ZviBaratz
reviewed
Jan 6, 2023
There was a problem hiding this comment.
Assuming I'm just missing something in the first comment re /, I think it looks great.
Also, I think using:
CACHING_OPTIONS = ty.Literal['fill', 'unchanged']
MMAP_OPTIONS = ty.Literal['c', 'r']and maybe even:
HeaderType = FileBasedHeader | ty.Mapping | Nonecould be nice, in terms of more concise function signatures and code readability. But it might also be too much. Your call.
effigies
force-pushed
the
type/primary_image_api
branch
from
9ddf0db to
570101b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this much is done, I'm putting it up here. If anybody is up for a review before the release, this can go in 5.0. If not, it can wait for 5.1.
SpatialImage is next on my list, but I didn't want to hold this up if it could get in.