Skip to content

Conversation

effigies
Copy link
Member

This PR has two significant issues that required changes:

  1. Recoders set instance variables based on their input parameters. These variables are always dict-like, but we can't know their names. Adding and annotating __getattr__ resolves this.
  2. The DtypeMapper used to allow for Recoders with numpy dtypes was dict-ish, but not quite enough to make annotating it straightforward. Subclassing from dict was sufficient.

Otherwise, it's a fiddly file, so it needs a careful check that I haven't changed the logic or missed renaming a variable.

@codecov
Copy link

codecov bot commented Jan 29, 2023

Codecov Report

Base: 92.16% // Head: 92.16% // No change to project coverage 👍

Coverage data is based on head (b3c3472) compared to base (b3c3472).
Patch has no changes to coverable lines.

❗ Current head b3c3472 differs from pull request most recent head 92c90ae. Consider uploading reports for the commit 92c90ae to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1189   +/-   ##
=======================================
  Coverage   92.16%   92.16%           
=======================================
  Files          97       97           
  Lines       12337    12337           
  Branches     2534     2534           
=======================================
  Hits        11371    11371           
  Misses        645      645           
  Partials      321      321           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@effigies effigies force-pushed the type/volumeutils branch 4 times, most recently from 234bc88 to 92eb7fd Compare January 31, 2023 14:01
@effigies effigies requested a review from ZviBaratz January 31, 2023 20:59
@ZviBaratz
Copy link
Contributor

Sorry, busy couple of days ahead. Will review beginning of next week if it's nothing urgent.

@effigies
Copy link
Member Author

effigies commented Feb 2, 2023

Please do not consider any review requests urgent. I'm treating it as a "this is ready" notification.

@effigies
Copy link
Member Author

effigies commented Feb 7, 2023

Thanks, Zvi!

@effigies effigies merged commit fc49243 into nipy:master Feb 7, 2023
@effigies effigies added this to the 5.1.0 milestone Mar 29, 2023
@effigies effigies deleted the type/volumeutils branch August 31, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants