Skip to content

FIX: Set MRS type to Nifti1Extension for backwards compatibility #1380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 23, 2024
Merged

FIX: Set MRS type to Nifti1Extension for backwards compatibility #1380

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1158240
FIX: Set MRS type to Nifti1Extension for backwards compatibility
effigies Oct 21, 2024
4c831cf
DOC: Add changelog entry
effigies Oct 21, 2024
af6b74c
DOC: Update changelog to note that .json() is a method
effigies Oct 21, 2024
56446e5
Bump release date
effigies Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions Changelog
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,17 @@ Eric Larson (EL), Demian Wassermann, Stephan Gerhard and Ross Markello (RM).

References like "pr/298" refer to github pull request numbers.

5.3.2 (Wednesday 23 October 2024)
=================================

Bug-fix release in the 5.3.x series.

Bug fixes
---------
* Restore MRS extension type to Nifti1Extension to maintain backwards compatibility.
(pr/1380) (CM)


5.3.1 (Tuesday 15 October 2024)
===============================

Expand All @@ -46,9 +57,9 @@ NiBabel 6.0 will drop support for Numpy 1.x.

New features
------------
* Update NIfTI extension protocol to include ``.content : bytes``, ``.text : str`` and ``.json : dict``
properties for accessing extension contents. Exceptions will be raised on ``.text`` and ``.json`` if
conversion fails. (pr/1336) (CM)
* Update NIfTI extension protocol to include ``.content : bytes``, ``.text : str`` and
``.json() : dict`` properties/methods for accessing extension contents.
Exceptions will be raised on ``.text`` and ``.json()`` if conversion fails. (pr/1336) (CM)

Enhancements
------------
Expand Down
2 changes: 1 addition & 1 deletion nibabel/nifti1.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -675,7 +675,7 @@ def _mangle(self, dataset: DicomDataset) -> bytes:
(38, 'eval', NiftiExtension),
(40, 'matlab', NiftiExtension),
(42, 'quantiphyse', NiftiExtension),
(44, 'mrs', NiftiExtension[dict[str, ty.Any]]),
(44, 'mrs', Nifti1Extension),
),
fields=('code', 'label', 'handler'),
)
Expand Down
Loading