Skip to content

ENH: Accept pathlib.Path objects where filenames are accepted #610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Oct 23, 2019
Merged

ENH: Accept pathlib.Path objects where filenames are accepted #610

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
180fd50
load save with pathlib.Path objects
CRiddler Mar 15, 2018
9835998
Merge branch 'master' into loadsave-pathlib_compat
CRiddler Jun 13, 2018
b44c06b
Merge branch 'master' into loadsave-pathlib_compat
effigies Aug 19, 2019
3346689
Add fn to coerce pathlike to string
CRiddler Sep 16, 2019
aaf1a19
Insert _stringify_path to entry points
CRiddler Sep 16, 2019
185f82c
Refactor _stringify_path to filename_parser.py
CRiddler Sep 17, 2019
e1d78c8
resolve flake8
CRiddler Sep 23, 2019
d9ce63e
testing for pathlib
CRiddler Oct 14, 2019
7887232
purge basestring
CRiddler Oct 14, 2019
6c0497e
move stringify guard to types_filenames
CRiddler Oct 16, 2019
e0fff5c
update docstrings to accept str or os.PathLike
CRiddler Oct 16, 2019
fbaeacc
Merge branch 'master' into loadsave-pathlib_compat
CRiddler Oct 16, 2019
6056014
update _stringify_path doc
CRiddler Oct 16, 2019
0cb7c39
update docstrings to accept str or os.PathLike
CRiddler Oct 16, 2019
ca10c44
mghformat accept pathlib for filespec_to_file_map
CRiddler Oct 16, 2019
e98dbfc
tests pathlib compatible
CRiddler Oct 16, 2019
6394536
update _stringify_path doc
CRiddler Oct 16, 2019
60a4624
Fix flake 8 issues
CRiddler Oct 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion nibabel/loadsave.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
from .filebasedimages import ImageFileError
from .imageclasses import all_image_classes
from .arrayproxy import is_proxy
from .py3k import FileNotFoundError
from .py3k import FileNotFoundError, unicode
from .deprecated import deprecate_with_version


Expand All @@ -36,6 +36,11 @@ def load(filename, **kwargs):
img : ``SpatialImage``
Image of guessed type
'''
if hasattr(filename, '__fspath__'):
filename = filename.__fspath__()
else:
filename = unicode(filename)

if not op.exists(filename):
raise FileNotFoundError("No such file: '%s'" % filename)
sniff = None
Expand Down