Skip to content

Conversation

effigies
Copy link
Member

Related to #786. It looks like Versioneer doesn't handle archives that don't include tags very well, so I'm verifying the usefulness of the current setup, and we'll need to find a way to make this work with Versioneer, if it's worth moving to Versioneer at all at this point.

@codecov
Copy link

codecov bot commented Aug 14, 2019

Codecov Report

Merging #791 into master will decrease coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #791      +/-   ##
==========================================
- Coverage   90.02%   89.87%   -0.15%     
==========================================
  Files          94       94              
  Lines       12018    12018              
  Branches     2136     2136              
==========================================
- Hits        10819    10801      -18     
- Misses        852      868      +16     
- Partials      347      349       +2
Impacted Files Coverage Δ
nibabel/environment.py 75% <0%> (-20%) ⬇️
nibabel/pkg_info.py 65.51% <0%> (-13.8%) ⬇️
nibabel/openers.py 78.22% <0%> (-3.23%) ⬇️
nibabel/casting.py 85.53% <0%> (-0.86%) ⬇️
nibabel/dft.py 80.48% <0%> (-0.61%) ⬇️
nibabel/nifti1.py 91.17% <0%> (-0.31%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f2c308...bec7b15. Read the comment docs.

@effigies
Copy link
Member Author

Does anybody actually do this? We have the machinery though, so I figure we should test it until we remove it.

@effigies effigies merged commit 10ad38a into nipy:master Aug 14, 2019
@effigies effigies deleted the ci/check_archive_install branch August 14, 2019 21:17
@effigies effigies added this to the 3.0.0 RC1 milestone Aug 15, 2019
@effigies effigies modified the milestones: 3.0.0 RC1, 3.0.0 Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant