Skip to content

Conversation

effigies
Copy link
Member

Been threatening this for a while, and are over a year behind schedule.

Closes #770.

@effigies effigies added this to the 3.0.0 RC1 milestone Aug 19, 2019
@codecov
Copy link

codecov bot commented Aug 19, 2019

Codecov Report

Merging #794 into master will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #794      +/-   ##
=========================================
+ Coverage    90.1%   90.2%   +0.09%     
=========================================
  Files          95      95              
  Lines       11879   12072     +193     
  Branches     2118    2181      +63     
=========================================
+ Hits        10704   10889     +185     
- Misses        834     837       +3     
- Partials      341     346       +5
Impacted Files Coverage Δ
nibabel/dataobj_images.py 95.08% <100%> (+0.08%) ⬆️
nibabel/pydicom_compat.py 89.28% <0%> (-10.72%) ⬇️
nibabel/nicom/dicomwrappers.py 92.72% <0%> (+1.19%) ⬆️
nibabel/openers.py 94.89% <0%> (+4.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba6d01a...1f124ea. Read the comment docs.

@effigies effigies merged commit e684bcc into nipy:master Aug 28, 2019
@effigies effigies deleted the deprecate_get_data branch August 28, 2019 00:45
effigies added a commit to effigies/nibabel that referenced this pull request Sep 15, 2019
@effigies effigies modified the milestones: 3.0.0 RC1, 3.0.0 Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate DataobjImage.get_data in nibabel 3.0
1 participant