Skip to content

BF: Fix hardcoded maximum number of CSA tags #798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 3, 2019
Merged

BF: Fix hardcoded maximum number of CSA tags #798

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d0e1bbd
Fix hardcoded maximum number of CSA tags
hbraunDSP Aug 29, 2019
19aa459
fix some whitespace
hbraunDSP Aug 29, 2019
250ccf8
Update nibabel/nicom/csareader.py
hbraunDSP Sep 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions nibabel/nicom/csareader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,9 +98,9 @@ def read(csa_str):
hdr_type = 1
csa_dict['type'] = hdr_type
csa_dict['n_tags'], csa_dict['check'] = up_str.unpack('2I')
if not 0 < csa_dict['n_tags'] <= 128:
if not 0 < csa_dict['n_tags'] <= MAX_CSA_ITEMS:
raise CSAReadError('Number of tags `t` should be '
'0 < t <= 128')
'0 < t <= %s' % MAX_CSA_ITEMS)
for tag_no in range(csa_dict['n_tags']):
name, vm, vr, syngodt, n_items, last3 = \
up_str.unpack('64si4s3i')
Expand Down