MNT: Fix configparser + python 2 deprecations #917
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also some style
Codecov Report
@@ Coverage Diff @@
## master #917 +/- ##
==========================================
- Coverage 91.81% 91.73% -0.09%
==========================================
Files 97 97
Lines 12359 12359
Branches 2177 2177
==========================================
- Hits 11348 11338 -10
- Misses 678 684 +6
- Partials 333 337 +4
Continue to review full report at Codecov.
|
effigies
reviewed
May 25, 2020
effigies
reviewed
May 25, 2020
| import configparser | ||
| except ImportError: | ||
| import ConfigParser as configparser | ||
| import configparser |
There was a problem hiding this comment.
While these are valid updates, I'm disinclined to change versioneer except for functional fixes, to keep any diffs focused.
There was a problem hiding this comment.
Ok, what about the changes after the imports? They are deprecated in py3.6
There was a problem hiding this comment.
Fair enough. Let's go ahead with these changes, then.
Co-authored-by: Chris Markiewicz <[email protected]>
|
LGTM. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor python 2 prints and imports
Also some style