Skip to content

Commit 5e6dd05

Browse files
authored
Merge pull request #1522 from shoshber/contributing
FIX don't run setup.py in Makefile
2 parents 725b738 + 603e7ed commit 5e6dd05

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed

CONTRIBUTING.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
* Use a descriptive prefix for your PR: ENH (enhancement), FIX, TST, DOC, STY, REF (refactor), WIP (Work in progress)
1414
* The person who accepts/merges your PR will include an update to the CHANGES file: prefix: description (URL of pull request)
1515
* Run `make check-before-commit` before submitting the PR.
16+
This will require you to either install or be in developer mode with: `python setup.py install/develop`.
1617
* In general, do not catch exceptions without good reason.
1718
* catching non-fatal exceptions.
1819
Log the exception as a warning.

Makefile

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,8 +70,6 @@ html:
7070
make -C doc clean htmlonly
7171

7272
specs:
73-
@echo "Setting up developer mode"
74-
python setup.py develop
7573
@echo "Checking specs and autogenerating spec tests"
7674
python tools/checkspecs.py
7775

0 commit comments

Comments
 (0)