Skip to content

ENH: Skip newline before Python call in batch submission to facilitate containerized runs #3297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 1, 2021
Merged

ENH: Skip newline before Python call in batch submission to facilitate containerized runs #3297

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7ad9461
Avoid empty line in bash script output
d-vogel Feb 4, 2021
5916043
Merge remote-tracking branch 'upstream/master' into d-vogel/master
effigies Apr 30, 2021
a60eb4e
Rather remove the newlines than trim the last char of the template.
d-vogel May 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion nipype/pipeline/plugins/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -543,7 +543,7 @@ def _submit_job(self, node, updatehash=False):
pyscript = create_pyscript(node, updatehash=updatehash)
batch_dir, name = os.path.split(pyscript)
name = ".".join(name.split(".")[:-1])
batchscript = "\n".join((self._template, "%s %s" % (sys.executable, pyscript)))
batchscript = "\n".join((self._template[:-1], "%s %s" % (sys.executable, pyscript)))
batchscriptfile = os.path.join(batch_dir, "batchscript_%s.sh" % name)
with open(batchscriptfile, "wt") as fp:
fp.writelines(batchscript)
Expand Down