-
Notifications
You must be signed in to change notification settings - Fork 84
Fix deprecation of shape assignment in numpy 2.5+ #236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Needs the same cmopatibility function as MNE for numpy < 2.1. |
|
This should be better, it adds however |
larsoner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me but I'll let @effigies merge if he's happy!
|
In #205 we settled on using SPEC 0, which says we should be dropping numpy<2 now anyway. I think we can get rid of all the compat stuff and just use the numpy 2 features. The minimum nibabel following SPEC 0 rules would be 5.3 (see https://github.com/nipreps/speczeroplus/blob/main/spec-0000/chart.md). |
|
However, this requires |
|
@mscheltienne I think @effigies is suggesting removing some of the existing shims (some of which were slightly tweaked here anyway) while you're messing around with this code |
|
Happy to remove the other elements which are in for |
|
As to reshape, let's just use |
|
@effigies Done! |
x-ref: mne-tools/mne-python#13585
Fixes:
And other occurrences.