Add tests for --error and --output as sbatch_args in test_submitter#638
Open
adi611 wants to merge 2 commits intonipype:mainfrom
Open
Add tests for --error and --output as sbatch_args in test_submitter#638adi611 wants to merge 2 commits intonipype:mainfrom
--error and --output as sbatch_args in test_submitter#638adi611 wants to merge 2 commits intonipype:mainfrom
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #638 +/- ##
===========================================
+ Coverage 38.27% 81.72% +43.44%
===========================================
Files 20 20
Lines 4394 4394
Branches 1202 0 -1202
===========================================
+ Hits 1682 3591 +1909
+ Misses 2417 803 -1614
+ Partials 295 0 -295
Flags with carried forward coverage won't be shown. Click here to find out more. see 18 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Contributor
|
This should be ported across |
Contributor
|
PR looking to address #630 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of changes
Summary
Added tests for valid
--errorand--outputassbatch_args.Checklist
I am getting error for

test_slurm_args_3while testing (which checks for--error) -AttributeError: 'NoneType' object has no attribute 'replace'Possible reason for this could be in workers.py here. In this, we are assigning
error_filetoNonewhen--errorflag is indeed detected. And later we are using.replace()function onerror_filewhich isNonein our case.