Skip to content

Conversation

@tclose
Copy link
Contributor

@tclose tclose commented Sep 20, 2024

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Summary

Update to the fileformats dependency to add support for static type checking broke a couple of tests (not the code-base itself). This PR fixes those tests.

Checklist

  • I have added tests to cover my changes (if necessary)
  • I have updated documentation (if necessary)

@tclose tclose changed the title fixes to unittests after typing refactor of fileformats into BinaryFile and UnicodeFile fixes tests after refactor of fileformats.generic.File into BinaryFile and UnicodeFile Sep 24, 2024
@tclose tclose changed the title fixes tests after refactor of fileformats.generic.File into BinaryFile and UnicodeFile Fixes tests after refactor of fileformats.generic.File into BinaryFile and UnicodeFile Sep 24, 2024
@tclose tclose marked this pull request as ready for review September 24, 2024 08:20
@tclose tclose requested a review from djarecka September 24, 2024 08:20
@tclose
Copy link
Contributor Author

tclose commented Sep 28, 2024

@djarecka this is just a minor PR that needs to merged in for the master branch to pass the tests. Do you mind if I do it myself? The only changes are cleaning up some typing and the use of BinaryFile and raw_contents instead of File and contents in a couple of tests

@effigies effigies closed this Mar 17, 2025
@effigies effigies reopened this Mar 17, 2025
@codecov
Copy link

codecov bot commented Mar 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@d674840). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #764   +/-   ##
=======================================
  Coverage        ?   89.11%           
=======================================
  Files           ?       55           
  Lines           ?    15789           
  Branches        ?     1379           
=======================================
  Hits            ?    14070           
  Misses          ?     1717           
  Partials        ?        2           
Flag Coverage Δ
unittests 89.16% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tclose tclose closed this Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants