Skip to content

Conversation

tclose
Copy link
Contributor

@tclose tclose commented Apr 29, 2025

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Summary

Fixes #757 by providing initial value to reduce functions

Checklist

  • I have added tests to cover my changes (if necessary)
  • I have updated documentation (if necessary)

Copy link

codecov bot commented Apr 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.75%. Comparing base (55c30c1) to head (7fccfef).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #818   +/-   ##
=======================================
  Coverage   88.75%   88.75%           
=======================================
  Files          84       84           
  Lines       17891    17891           
  Branches     3487     3483    -4     
=======================================
  Hits        15879    15879           
  Misses       1642     1642           
  Partials      370      370           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tclose tclose requested a review from effigies April 30, 2025 00:36
Copy link
Contributor

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's clearer just to use math.prod (needs import), rather than reimplement it with reduce.

tclose and others added 5 commits May 6, 2025 09:02
Co-authored-by: Chris Markiewicz <[email protected]>
Co-authored-by: Chris Markiewicz <[email protected]>
Co-authored-by: Chris Markiewicz <[email protected]>
Co-authored-by: Chris Markiewicz <[email protected]>
@tclose tclose merged commit 964793d into main May 6, 2025
30 checks passed
@tclose tclose deleted the reduce-initial-value branch May 6, 2025 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Singleton splitter 1D split bug in state.py:_single_op_splits

2 participants