Conversation
singlamohit1
force-pushed
the
feat/save-org
branch
2 times, most recently
from
6cf000e to
d1020ba
Compare
singlamohit1
force-pushed
the
feat/save-org
branch
from
d1020ba to
da44e13
Compare
|
|
@nishantwrp @singlamohit1 your views? |
|
@singlamohit1 are you still working on this? Please address my comments. Thanks! |
beingnoble03
left a comment
beingnoble03
left a comment
There was a problem hiding this comment.
I think there should an option to bookmark an organization in it's info page too.
For design, I think we can do the same thing, we did in the Organizations List Page.
Your views @nishantwrp @singlamohit1 ?
|
After an offline discussion with @nishantwrp, got to know that this was already discussed. Please ignore. |
singlamohit1
force-pushed
the
feat/save-org
branch
from
b254bb8 to
5a7f8b8
Compare
| import { addCount, removeCount } from "../store/bookmark" | ||
| import { Icon } from "semantic-ui-react" | ||
|
|
||
| const getIfOrgSaved = orgname => { |
There was a problem hiding this comment.
Should we change this to getIsOrgBookmarked?
| } | ||
| } | ||
| const OrgCard = ({ data }) => { | ||
| const [ifOrgNotSaved, setIfOrgSaved] = useState( |
There was a problem hiding this comment.
Should we change this to [isOrgBookmarked, setIsOrgBookmarked]?
| .reverse() | ||
|
|
||
| const addOrRemoveBookmark = value => { | ||
| let isPresent = getIfOrgSaved(value) |
There was a problem hiding this comment.
Should we change this to isBookmarked?
| }) | ||
| .reverse() | ||
|
|
||
| const addOrRemoveBookmark = value => { |
There was a problem hiding this comment.
Should we change this to toggleBookmark?
| localStorage.setItem("gsoc_orgs", JSON.stringify(curr_orgs)) | ||
| } | ||
| return | ||
| } |
| return | ||
| } | ||
|
|
||
| export function removeOrgToShortlist(orgname) { |
There was a problem hiding this comment.
Should we change this to removeOrgFromBookmarks?
| @@ -0,0 +1,72 @@ | |||
| import { createSlice } from "@reduxjs/toolkit" | |||
|
|
|||
| export function addOrgToShortlist(orgname) { | |||
There was a problem hiding this comment.
Should we change this to addOrgToBookmarks?
beingnoble03
left a comment
beingnoble03
left a comment
There was a problem hiding this comment.
Some variable name changes. Rest LGTM.
|
@nishantwrp Can you pls review the PR. It has been months now. I want to work on more features once this gets live. |
|
@beingnoble03 Can you review the PR since Nishant seems busy |
|
@singlamohit1 you didn't accept the requested changes. |
|
@nishantwrp please review. |
|
@nishantwrp @singlamohit1 do you think we can have the bookmark feat? :) |
yes |
2 participants
Fixes #85