Open
Conversation
nisrulz
reviewed
Nov 3, 2023
| } | ||
|
|
||
| android { | ||
| namespace "com.example.calculator" |
Owner
There was a problem hiding this comment.
Please follow the readme properly.
nisrulz
reviewed
Nov 3, 2023
Owner
There was a problem hiding this comment.
Optimize this gif down to 480x320 size using this service
nisrulz
reviewed
Nov 3, 2023
Owner
There was a problem hiding this comment.
Delete this file as it is not useful.
nisrulz
reviewed
Nov 3, 2023
Owner
nisrulz
left a comment
nisrulz
left a comment
There was a problem hiding this comment.
Code looks fine to me, however please address the comments I have added.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes
Simple calculator example
Does this close any currently open issues?
Where has this been tested?
Android A22
Target Platform:
Android
Demo:
XRecorder_Edited_31102023_072709.mp4