Fix lazy loading race conditions and missing EnsureLoaded calls in XSSFSheet#1678
Draft
Fix lazy loading race conditions and missing EnsureLoaded calls in XSSFSheet#1678
Conversation
…cess worksheet field in XSSFSheet.cs Co-authored-by: tonyqus <772561+tonyqus@users.noreply.github.com>
Co-authored-by: tonyqus <772561+tonyqus@users.noreply.github.com>
Co-authored-by: tonyqus <772561+tonyqus@users.noreply.github.com>
Co-authored-by: tonyqus <772561+tonyqus@users.noreply.github.com>
Co-authored-by: tonyqus <772561+tonyqus@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Load sheet only when XSSFSheet object is used
Implement lazy loading for XSSFSheet
Feb 3, 2026
Copilot stopped work on behalf of
tonyqus due to an error
February 3, 2026 16:18
Copilot stopped work on behalf of
tonyqus due to an error
February 3, 2026 16:18
Copilot stopped work on behalf of
tonyqus due to an error
February 3, 2026 16:19
Co-authored-by: tonyqus <772561+tonyqus@users.noreply.github.com>
Copilot
AI
changed the title
Implement lazy loading for XSSFSheet
Fix stack overflow in lazy sheet loading from recursive EnsureLoaded
Feb 3, 2026
…tingRowsAndColumns Co-authored-by: tonyqus <772561+tonyqus@users.noreply.github.com>
Copilot
AI
changed the title
Fix stack overflow in lazy sheet loading from recursive EnsureLoaded
Add missing EnsureLoaded call to SetRepeatingRowsAndColumns
Feb 3, 2026
Co-authored-by: tonyqus <772561+tonyqus@users.noreply.github.com>
Copilot
AI
changed the title
Add missing EnsureLoaded call to SetRepeatingRowsAndColumns
Fix lazy loading race conditions and missing EnsureLoaded calls in XSSFSheet
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recent lazy loading implementation in XSSFSheet introduced three categories of failures where methods accessed uninitialized fields before calling
EnsureLoaded().Changes
Stack overflow fix: Set
isLoaded = truebefore callingRead()inOnDocumentRead()instead of after. XSSFRow constructor accessesLastRowNumduring initialization, which callsEnsureLoaded()again, causing infinite recursion when flag is set post-load.SetRepeatingRowsAndColumns: Added
EnsureLoaded()call. Method accessesworksheet.IsSetPageSetup()andworksheet.IsSetPageMargins()which are null until sheet loads.GetTables: Added
EnsureLoaded()call. Method accessestablesdictionary which is initialized inInitRows()during load.Test Results
All fixes follow the existing pattern where methods accessing sheet state initialized during load must call
EnsureLoaded()first.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.