Fix SaveXmlInStreamAsync disposing stream prematurely#1680
Draft
Fix SaveXmlInStreamAsync disposing stream prematurely#1680
Conversation
Co-authored-by: tonyqus <772561+tonyqus@users.noreply.github.com>
Co-authored-by: tonyqus <772561+tonyqus@users.noreply.github.com>
…peManager bug Co-authored-by: tonyqus <772561+tonyqus@users.noreply.github.com>
Co-authored-by: tonyqus <772561+tonyqus@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Implement XSSFWorkbook.WriteAsync method with true async support
Implement XSSFWorkbook.WriteAsync with true async I/O
Feb 3, 2026
Co-authored-by: tonyqus <772561+tonyqus@users.noreply.github.com>
Copilot
AI
changed the title
Implement XSSFWorkbook.WriteAsync with true async I/O
Implement SaveAsync for MemoryPackagePart and PackagePropertiesPart
Feb 3, 2026
Co-authored-by: tonyqus <772561+tonyqus@users.noreply.github.com>
Copilot
AI
changed the title
Implement SaveAsync for MemoryPackagePart and PackagePropertiesPart
Fix SaveXmlInStreamAsync disposing stream prematurely
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SaveXmlInStreamAsyncused ausingstatement that disposed the XmlWriter, closing the underlying ZipOutputStream before all entries were written. Reading back resulted in "root element missing" exceptions.Changes
usingstatement, manually flush without disposalCloseOutput = falsefor consistencyAsync now matches sync pattern - caller owns stream lifecycle.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.