Skip to content

add feature: add subprocess element support (continued)#264

Merged
nitram509 merged 15 commits intomainfrom
feature/add-subprocess
Apr 19, 2025
Merged

add feature: add subprocess element support (continued)#264
nitram509 merged 15 commits intomainfrom
feature/add-subprocess

Conversation

@nitram509
Copy link
Owner

@nitram509 nitram509 commented Apr 18, 2025

Motivation/Abstract

adding support for SubProcess elements in BPMN

fixes #246

Description/Comments

Based on the great work from #247 , this changes some aspects of the implementation.

  • keeping the helper functions FindSequenceFlows() and FindFirstSequenceFlow() in their current place
  • passing an activity object to handle process and subProcess (instead of just the state)

Checklist

Depending on your PR, please ensure the overall consistency/integrity of the project remains.
Please tick just one check item per section below

Tests

  • did you update or create tests for your code changes?
  • not relevant

Code examples

  • did you update or add example code snippets, which relate to your code changes
  • not relevant

Documentation

  • did you update or create documentation, which relates to your code changes
  • not relevant

@nitram509 nitram509 changed the title feat(add subprocess): add feature: add subprocess element support (continued) Apr 18, 2025
@codecov
Copy link

codecov bot commented Apr 18, 2025

Codecov Report

Attention: Patch coverage is 40.92827% with 140 lines in your changes missing coverage. Please review.

Project coverage is 63.76%. Comparing base (42caf7b) to head (da2f569).
Report is 20 commits behind head on main.

Files with missing lines Patch % Lines
pkg/spec/BPMN20/elements.go 0.00% 68 Missing ⚠️
pkg/spec/BPMN20/helper.go 0.00% 43 Missing ⚠️
pkg/bpmn_engine/engine.go 83.58% 10 Missing and 1 partial ⚠️
pkg/bpmn_engine/marshalling.go 9.09% 10 Missing ⚠️
pkg/bpmn_engine/process_instance.go 55.55% 4 Missing ⚠️
pkg/bpmn_engine/sub_process.go 75.00% 2 Missing ⚠️
pkg/bpmn_engine/timer.go 80.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #264      +/-   ##
==========================================
- Coverage   66.02%   63.76%   -2.26%     
==========================================
  Files          27       28       +1     
  Lines        1757     1896     +139     
==========================================
+ Hits         1160     1209      +49     
- Misses        553      642      +89     
- Partials       44       45       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nitram509 nitram509 marked this pull request as ready for review April 18, 2025 14:23
@nitram509 nitram509 force-pushed the feature/add-subprocess branch from 3a3d61c to fe41445 Compare April 18, 2025 15:37
@nitram509 nitram509 merged commit df05e1f into main Apr 19, 2025
8 of 10 checks passed
@nitram509 nitram509 deleted the feature/add-subprocess branch April 19, 2025 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add feature - Sub Process element

2 participants