Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #268 +/- ##
==========================================
+ Coverage 63.44% 63.81% +0.36%
==========================================
Files 28 28
Lines 1896 1915 +19
==========================================
+ Hits 1203 1222 +19
Misses 647 647
Partials 46 46 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Hi @nitram509, any comment on this PR? We've been using this successfully in our implementation |
Owner
Hi @trojanc, thanks for the nudge ... my spare time is limited ... but I will look into this the next days. |
Owner
|
Great job, @trojanc 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation/Abstract
Description/Comments
If the timer value starts with
=it is assumed to be an expression, and will be evaluatedChecklist
Depending on your PR, please ensure the overall consistency/integrity of the project remains.
Please tick just one check item per section below
Tests
Code examples
Documentation