Skip to content

Add FEEL support to timers#268

Merged
nitram509 merged 1 commit intonitram509:mainfrom
trojanc:timer-feel
Jun 21, 2025
Merged

Add FEEL support to timers#268
nitram509 merged 1 commit intonitram509:mainfrom
trojanc:timer-feel

Conversation

@trojanc
Copy link
Contributor

@trojanc trojanc commented May 11, 2025

Motivation/Abstract

  • Need to support timers values being evaluated from a FEEL expression

Description/Comments

If the timer value starts with = it is assumed to be an expression, and will be evaluated

Checklist

Depending on your PR, please ensure the overall consistency/integrity of the project remains.
Please tick just one check item per section below

Tests

  • did you update or create tests for your code changes?
  • not relevant

Code examples

  • did you update or add example code snippets, which relate to your code changes
  • not relevant

Documentation

  • did you update or create documentation, which relates to your code changes
  • not relevant

@codecov
Copy link

codecov bot commented May 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.81%. Comparing base (bf154b2) to head (2372cf2).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #268      +/-   ##
==========================================
+ Coverage   63.44%   63.81%   +0.36%     
==========================================
  Files          28       28              
  Lines        1896     1915      +19     
==========================================
+ Hits         1203     1222      +19     
  Misses        647      647              
  Partials       46       46              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@trojanc
Copy link
Contributor Author

trojanc commented Jun 5, 2025

Hi @nitram509, any comment on this PR? We've been using this successfully in our implementation

@nitram509
Copy link
Owner

nitram509 commented Jun 6, 2025

Hi @nitram509, any comment on this PR? We've been using this successfully in our implementation

Hi @trojanc, thanks for the nudge ... my spare time is limited ... but I will look into this the next days.

@nitram509
Copy link
Owner

Great job, @trojanc 👍
Thanks for your contribution 🚀

@nitram509 nitram509 merged commit b9e5c2e into nitram509:main Jun 21, 2025
7 checks passed
@trojanc trojanc deleted the timer-feel branch October 24, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants