Skip to content

Fix task handlers for multiple process instances with same user task IDs #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nitram509 merged 4 commits into from
Aug 24, 2025
Merged

Fix task handlers for multiple process instances with same user task IDs #279

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ac4f7a2
Fix task handlers for multiple process instances with same user task IDs
erinoggz Jul 29, 2025
55dea55
Add test for handling multiple instances with the same user task IDs
erinoggz Jul 29, 2025
eb95dac
Add BPMN file for user tasks with parallel gateways
erinoggz Jul 29, 2025
14ebb9c
improve clarity for multiple instances test
erinoggz Jul 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/bpmn_engine/jobs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ func (j job) Element() *BPMN20.BaseElement {
func findOrCreateJob(jobs *[]*job, element *BPMN20.TaskElement, instance *processInstanceInfo, generateKey func() int64) *job {
be := (*element).(BPMN20.BaseElement)
for _, job := range *jobs {
if job.ElementId == be.GetId() {
if job.ElementId == be.GetId() && job.ProcessInstanceKey == instance.GetInstanceKey() {
return job
}
}
Expand Down
41 changes: 41 additions & 0 deletions pkg/bpmn_engine/jobs_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,3 +339,44 @@ func Test_missing_task_handlers_break_execution_and_can_be_continued_later(t *te
then.AssertThat(t, err, is.Nil())
then.AssertThat(t, cp.CallPath, is.EqualTo("id-a-1,id-b-1,id-b-2"))
}

func Test_multiple_instances_with_same_user_task_ids(t *testing.T) {
// setup
bpmnEngine := New()
process, err := bpmnEngine.LoadFromFile("../../test-cases/user-tasks-with-parallel-gateways.bpmn")
then.AssertThat(t, err, is.Nil())

called := map[int64][]string{}
handler := func(taskId string) func(ActivatedJob) {
return func(job ActivatedJob) {
called[job.ProcessInstanceKey()] = append(called[job.ProcessInstanceKey()], taskId)
job.Complete()
}
}

// given
bpmnEngine.NewTaskHandler().Id("assignee-task1").Handler(handler("assignee-task1"))
bpmnEngine.NewTaskHandler().Id("assignee-task2").Handler(handler("assignee-task2"))
bpmnEngine.NewTaskHandler().Id("assignee-task3").Handler(handler("assignee-task3"))
bpmnEngine.NewTaskHandler().Id("assignee-task4").Handler(handler("assignee-task4"))

instance1, err1 := bpmnEngine.CreateAndRunInstance(process.ProcessKey, nil)
then.AssertThat(t, err1, is.Nil())
then.AssertThat(t, instance1, is.Not(is.Nil()))

instance2, err2 := bpmnEngine.CreateAndRunInstance(process.ProcessKey, nil)
then.AssertThat(t, err2, is.Nil())
then.AssertThat(t, instance2, is.Not(is.Nil()))

// when
_, err1c := bpmnEngine.RunOrContinueInstance(instance1.GetInstanceKey())
_, err2c := bpmnEngine.RunOrContinueInstance(instance2.GetInstanceKey())

// then
then.AssertThat(t, err1c, is.Nil())
then.AssertThat(t, err2c, is.Nil())
then.AssertThat(t, instance1.GetState(), is.EqualTo(Completed))
then.AssertThat(t, instance2.GetState(), is.EqualTo(Completed))
then.AssertThat(t, called[instance1.GetInstanceKey()], has.Length(4))
then.AssertThat(t, called[instance2.GetInstanceKey()], has.Length(4))
}
126 changes: 126 additions & 0 deletions test-cases/user-tasks-with-parallel-gateways.bpmn
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,126 @@
<?xml version="1.0" encoding="UTF-8"?>
<bpmn:definitions xmlns:bpmn="http://www.omg.org/spec/BPMN/20100524/MODEL" xmlns:bpmndi="http://www.omg.org/spec/BPMN/20100524/DI" xmlns:dc="http://www.omg.org/spec/DD/20100524/DC" xmlns:zeebe="http://camunda.org/schema/zeebe/1.0" xmlns:di="http://www.omg.org/spec/DD/20100524/DI" xmlns:modeler="http://camunda.org/schema/modeler/1.0" id="Definitions_1u3x2yl" targetNamespace="http://bpmn.io/schema/bpmn" exporter="Camunda Modeler" exporterVersion="5.3.0" modeler:executionPlatform="Camunda Cloud" modeler:executionPlatformVersion="1.0.0">
<bpmn:process id="user-tasks-with-assignments" name="user-tasks-with-assignments" isExecutable="true">
<bpmn:startEvent id="StartEvent_1">
<bpmn:outgoing>Flow_0xt1d7q</bpmn:outgoing>
</bpmn:startEvent>
<bpmn:sequenceFlow id="Flow_0xt1d7q" sourceRef="StartEvent_1" targetRef="Gateway_0vr3shh" />
<bpmn:userTask id="assignee-task1" name="assignee-task1">
<bpmn:extensionElements>
<zeebe:assignmentDefinition assignee="assignee" />
<zeebe:formDefinition formKey="form-key" />
</bpmn:extensionElements>
<bpmn:incoming>Flow_05og6fe</bpmn:incoming>
<bpmn:outgoing>Flow_1yi8zvd</bpmn:outgoing>
</bpmn:userTask>
<bpmn:sequenceFlow id="Flow_1yi8zvd" sourceRef="assignee-task1" targetRef="assignee-task4" />
<bpmn:endEvent id="Event_13981zj">
<bpmn:incoming>Flow_1qo8x2a</bpmn:incoming>
</bpmn:endEvent>
<bpmn:sequenceFlow id="Flow_1nvo18e" sourceRef="assignee-task4" targetRef="Gateway_0j4qy72" />
<bpmn:userTask id="assignee-task4" name="assignee-task4">
<bpmn:extensionElements>
<zeebe:assignmentDefinition assignee="assignee" />
</bpmn:extensionElements>
<bpmn:incoming>Flow_1yi8zvd</bpmn:incoming>
<bpmn:outgoing>Flow_1nvo18e</bpmn:outgoing>
</bpmn:userTask>
<bpmn:userTask id="assignee-task2" name="assignee-task2">
<bpmn:extensionElements>
<zeebe:assignmentDefinition assignee="assignee" />
<zeebe:formDefinition formKey="form-key" />
</bpmn:extensionElements>
<bpmn:incoming>Flow_1qupj9f</bpmn:incoming>
<bpmn:outgoing>Flow_0wdizhy</bpmn:outgoing>
</bpmn:userTask>
<bpmn:userTask id="assignee-task3" name="assignee-task3">
<bpmn:extensionElements>
<zeebe:assignmentDefinition assignee="assignee" />
<zeebe:formDefinition formKey="form-key" />
</bpmn:extensionElements>
<bpmn:incoming>Flow_0wdizhy</bpmn:incoming>
<bpmn:outgoing>Flow_1xqmkxd</bpmn:outgoing>
</bpmn:userTask>
<bpmn:sequenceFlow id="Flow_1qo8x2a" sourceRef="Gateway_0j4qy72" targetRef="Event_13981zj" />
<bpmn:sequenceFlow id="Flow_05og6fe" sourceRef="Gateway_0vr3shh" targetRef="assignee-task1" />
<bpmn:sequenceFlow id="Flow_1qupj9f" sourceRef="Gateway_0vr3shh" targetRef="assignee-task2" />
<bpmn:sequenceFlow id="Flow_0wdizhy" sourceRef="assignee-task2" targetRef="assignee-task3" />
<bpmn:sequenceFlow id="Flow_1xqmkxd" sourceRef="assignee-task3" targetRef="Gateway_0j4qy72" />
<bpmn:parallelGateway id="Gateway_0j4qy72">
<bpmn:incoming>Flow_1nvo18e</bpmn:incoming>
<bpmn:incoming>Flow_1xqmkxd</bpmn:incoming>
<bpmn:outgoing>Flow_1qo8x2a</bpmn:outgoing>
</bpmn:parallelGateway>
<bpmn:parallelGateway id="Gateway_0vr3shh">
<bpmn:incoming>Flow_0xt1d7q</bpmn:incoming>
<bpmn:outgoing>Flow_05og6fe</bpmn:outgoing>
<bpmn:outgoing>Flow_1qupj9f</bpmn:outgoing>
</bpmn:parallelGateway>
</bpmn:process>
<bpmndi:BPMNDiagram id="BPMNDiagram_1">
<bpmndi:BPMNPlane id="BPMNPlane_1" bpmnElement="user-tasks-with-assignments">
<bpmndi:BPMNShape id="_BPMNShape_StartEvent_2" bpmnElement="StartEvent_1">
<dc:Bounds x="112" y="99" width="36" height="36" />
</bpmndi:BPMNShape>
<bpmndi:BPMNShape id="Activity_102w2rp_di" bpmnElement="assignee-task1">
<dc:Bounds x="300" y="77" width="100" height="80" />
<bpmndi:BPMNLabel />
</bpmndi:BPMNShape>
<bpmndi:BPMNShape id="Event_13981zj_di" bpmnElement="Event_13981zj">
<dc:Bounds x="752" y="99" width="36" height="36" />
</bpmndi:BPMNShape>
<bpmndi:BPMNShape id="Activity_0o75bye_di" bpmnElement="assignee-task4">
<dc:Bounds x="470" y="77" width="100" height="80" />
<bpmndi:BPMNLabel />
</bpmndi:BPMNShape>
<bpmndi:BPMNShape id="BPMNShape_1u096ea" bpmnElement="assignee-task2">
<dc:Bounds x="300" y="-70" width="100" height="80" />
<bpmndi:BPMNLabel />
</bpmndi:BPMNShape>
<bpmndi:BPMNShape id="BPMNShape_1r9vrob" bpmnElement="assignee-task3">
<dc:Bounds x="460" y="-70" width="100" height="80" />
<bpmndi:BPMNLabel />
</bpmndi:BPMNShape>
<bpmndi:BPMNShape id="Gateway_1u6njpc_di" bpmnElement="Gateway_0j4qy72">
<dc:Bounds x="645" y="92" width="50" height="50" />
</bpmndi:BPMNShape>
<bpmndi:BPMNShape id="Gateway_0ljyn6i_di" bpmnElement="Gateway_0vr3shh">
<dc:Bounds x="215" y="92" width="50" height="50" />
</bpmndi:BPMNShape>
<bpmndi:BPMNEdge id="Flow_0xt1d7q_di" bpmnElement="Flow_0xt1d7q">
<di:waypoint x="148" y="117" />
<di:waypoint x="215" y="117" />
</bpmndi:BPMNEdge>
<bpmndi:BPMNEdge id="Flow_1yi8zvd_di" bpmnElement="Flow_1yi8zvd">
<di:waypoint x="400" y="117" />
<di:waypoint x="470" y="117" />
</bpmndi:BPMNEdge>
<bpmndi:BPMNEdge id="Flow_1nvo18e_di" bpmnElement="Flow_1nvo18e">
<di:waypoint x="570" y="117" />
<di:waypoint x="645" y="117" />
</bpmndi:BPMNEdge>
<bpmndi:BPMNEdge id="Flow_1qo8x2a_di" bpmnElement="Flow_1qo8x2a">
<di:waypoint x="695" y="117" />
<di:waypoint x="752" y="117" />
</bpmndi:BPMNEdge>
<bpmndi:BPMNEdge id="Flow_05og6fe_di" bpmnElement="Flow_05og6fe">
<di:waypoint x="265" y="117" />
<di:waypoint x="300" y="117" />
</bpmndi:BPMNEdge>
<bpmndi:BPMNEdge id="Flow_1qupj9f_di" bpmnElement="Flow_1qupj9f">
<di:waypoint x="240" y="92" />
<di:waypoint x="240" y="-30" />
<di:waypoint x="300" y="-30" />
</bpmndi:BPMNEdge>
<bpmndi:BPMNEdge id="Flow_0wdizhy_di" bpmnElement="Flow_0wdizhy">
<di:waypoint x="400" y="-30" />
<di:waypoint x="460" y="-30" />
</bpmndi:BPMNEdge>
<bpmndi:BPMNEdge id="Flow_1xqmkxd_di" bpmnElement="Flow_1xqmkxd">
<di:waypoint x="560" y="-30" />
<di:waypoint x="670" y="-30" />
<di:waypoint x="670" y="92" />
</bpmndi:BPMNEdge>
</bpmndi:BPMNPlane>
</bpmndi:BPMNDiagram>
</bpmn:definitions>
Loading