feat(aws): Allow stack configuration of Aurora RDS scaling#727
Merged
feat(aws): Allow stack configuration of Aurora RDS scaling#727
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #727 +/- ##
=======================================
Coverage 48.75% 48.75%
=======================================
Files 28 28
Lines 3546 3546
=======================================
Hits 1729 1729
Misses 1698 1698
Partials 119 119
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
davemooreuws
approved these changes
Feb 4, 2025
resolves an issue with 'down' operations
raksiv
approved these changes
Feb 6, 2025
|
🎉 This PR is included in version 1.17.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows the following config to be added to stack files using the
nitric/awsprovider:Which allows the scaling values to be modified from the defaults, including allowing auto-pause.
The engine version was bumped from
13.14to13.16, since 13.14 doesn't support pausing. This change may cause an outage for existing database clusters using the previous version (see: The AWS Docs for more details)Upgrade Steps
A note when updating from a previous nitric provider version with an existing database cluster. You'll need to update first before adding auto-pause settings. The database engine version needs to be updated to support auto-pausing before the settings can be applied.
Here are the steps:
nitric up, this will update the database cluster versionnitric upagain, this time to apply the new settingsIf this isn't done, you'll get this error when deploying
Auto-pause isn't supported by engine version 13.14, please upgrade to a supported version first.