-
-
Notifications
You must be signed in to change notification settings - Fork 5
feat: add vue-router-ssr example with SSR assets API #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hi-ogawa
wants to merge
19
commits into
nitrojs:main
Choose a base branch
from
hi-ogawa:10-02-feat_add_vue-router-ssr_example
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: add vue-router-ssr example with SSR assets API #5
hi-ogawa
wants to merge
19
commits into
nitrojs:main
from
hi-ogawa:10-02-feat_add_vue-router-ssr_example
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey 👋
This is very early prototype, but I wanted to share with you to get feedback. You can find a rough documentation in https://github.com/hi-ogawa/vite-plugins/tree/main/packages/fullstack.
This PR adds vue-router-ssr example. This is based on the one example on my repo but use
nitro/vite
for server handler instead https://github.com/hi-ogawa/vite-plugins/tree/main/packages/fullstack/examples/vue-router.Development is working but production is currently failing. I haven't tested with latest nightly, so that might fix it.(EDIT: works with the updated nitro-nightly!)Currently it doesn't work with(EDIT: this works too now with a slight limitation)nitro
environment directly usingserver.ts
convention. Development actually works but build fails. I might need more investigation on this.