Add scheduled effects - #556
Merged
Merged
Conversation
phaer
force-pushed
the
scheduled-effects
branch
4 times, most recently
from
January 20, 2026 11:05
152429c to
c866ab2
Compare
phaer
marked this pull request as ready for review
January 23, 2026 12:38
phaer
force-pushed
the
scheduled-effects
branch
3 times, most recently
from
January 28, 2026 11:50
8767385 to
5b2cd21
Compare
Member
Author
|
EDIT: solved by rebasing, which re-triggered CI |
phaer
force-pushed
the
scheduled-effects
branch
from
January 28, 2026 15:19
5b2cd21 to
2974d1c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the ability to run scheduled effects, as in hercules-ci's
onSchedule.Useful for periodic flake updates & similar jobs.
Drafted for now, as I'd like to test it a bit more and add small improvements before merging. Such as randomizing hours & minutes if left unspecified, cleanup up the test a little & add one for
onPusheffects as well.But happy for feedback on design & implementation. At least the basics seem to work, it successfully ran scheduled tasks on my private buildbot-nix instance.
(includes #555)