Skip to content

nix/clan-module: init#557

Open
MagicRB wants to merge 12 commits intonix-community:mainfrom
MagicRB:feat/clan-module
Open

nix/clan-module: init#557
MagicRB wants to merge 12 commits intonix-community:mainfrom
MagicRB:feat/clan-module

Conversation

@MagicRB
Copy link
Contributor

@MagicRB MagicRB commented Jan 20, 2026

The new module options doc rendered

@MagicRB MagicRB marked this pull request as draft January 20, 2026 13:12
@MagicRB MagicRB force-pushed the feat/clan-module branch 2 times, most recently from ae5a74a to 190645f Compare January 20, 2026 14:08
package = inputs.niks3.packages.${pkgs.system}.default;
};
# authTokenFile = config.clan.core.vars.generators.niks3-api-token.files."token".path;
# package = inputs.niks3.packages.${pkgs.system}.default;
Copy link
Member

@Mic92 Mic92 Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In clan we do set self in specialArgs. A bit of a hacky fix would be to do:

package = lib.mkIf (self.inputs ? niks3) (lib.mkDefault self.inputs.niks3.${pkgs.system}.default);

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, self is the toplevel flake? that was the info i was missing, thanks

@MagicRB MagicRB force-pushed the feat/clan-module branch 2 times, most recently from 9c8b884 to eef700f Compare January 20, 2026 16:19
@MagicRB
Copy link
Contributor Author

MagicRB commented Jan 20, 2026

@Mic92 i added a super basic option doc thing in the last commit, with the split options the approach of "look at the source code" wont work. IMO it would be too hard for people to parse 2 separate Nix files, especially with the mapping i have to do. Not sure how we could have MD option docs for this repo, ive never done that. Any suggestions?

@MagicRB MagicRB force-pushed the feat/clan-module branch 3 times, most recently from 09b75b5 to ac59195 Compare January 27, 2026 11:12
@MagicRB MagicRB force-pushed the feat/clan-module branch 6 times, most recently from ee61f4b to fee3b72 Compare February 4, 2026 13:08
@MagicRB MagicRB marked this pull request as ready for review February 4, 2026 13:08
Signed-off-by: magic_rb <richard@brezak.sk>
Signed-off-by: magic_rb <richard@brezak.sk>
Signed-off-by: magic_rb <richard@brezak.sk>
Signed-off-by: magic_rb <richard@brezak.sk>
Signed-off-by: magic_rb <richard@brezak.sk>
Signed-off-by: magic_rb <richard@brezak.sk>
Signed-off-by: magic_rb <richard@brezak.sk>
Signed-off-by: magic_rb <richard@brezak.sk>
Signed-off-by: magic_rb <richard@brezak.sk>
Signed-off-by: magic_rb <richard@brezak.sk>
Signed-off-by: magic_rb <richard@brezak.sk>
@MagicRB MagicRB force-pushed the feat/clan-module branch 2 times, most recently from 7bc3444 to fbf91b5 Compare February 16, 2026 13:07
@MagicRB
Copy link
Contributor Author

MagicRB commented Feb 16, 2026

depends on #574 which seems to have triggered some treefmt complaints. (this PR fixes some checks that weren't being ran before, which means #576 is actually not passing checks but I didnt know)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants