webhooks: update existing hooks to sync secret on reload#558
Draft
webhooks: update existing hooks to sync secret on reload#558
Conversation
GitHub and Gitea do not expose webhook secrets via their APIs, making it impossible to detect when the local webhookSecretFile has been rotated. Previously, buildbot-nix would skip hook creation if a hook with matching URL already existed, leaving stale secrets in place and causing webhook signature verification failures. Use PATCH to update existing hooks instead of returning early. This ensures the webhook configuration (including the secret) stays in sync whenever the reload builder runs.
Mic92
force-pushed
the
webhook-reload
branch
from
6d2f4e2 to
d26ddce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub and Gitea do not expose webhook secrets via their APIs, making it impossible to detect when the local webhookSecretFile has been rotated. Previously, buildbot-nix would skip hook creation if a hook with matching URL already existed, leaving stale secrets in place and causing webhook signature verification failures.
Use PATCH to update existing hooks instead of returning early. This ensures the webhook configuration (including the secret) stays in sync whenever the reload builder runs.