Allow repos to enable effects on pull requests and additional branches#581
Merged
Allow repos to enable effects on pull requests and additional branches#581
Conversation
Mic92
force-pushed
the
effects-config
branch
3 times, most recently
from
d458c18 to
b5aa5d5
Compare
Effects are useful for deployment and other impure CI steps, but until now they were restricted to the default branch. Some workflows need effects on pull requests (e.g. preview deployments) or on additional branches like staging or release branches. Add two new settings to the per-repo buildbot-nix.toml: effects_on_pull_requests (bool) and effects_branches (list of glob patterns). Both default to off, preserving existing behavior. To prevent a malicious PR from granting itself effects access, these settings are always read from origin/<default_branch> via git show, never from the PR worktree. For PR builds, GitLocalPrMerge now fetches the default branch ref alongside the PR SHAs so the ref stays current. Also fix get_project_url() dropping the port from the Gitea instance URL (url.hostname strips port), causing git clone to fail when Gitea runs on a non-standard port.
Mic92
force-pushed
the
effects-config
branch
from
b5aa5d5 to
57d1baa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.