Skip to content

fix: the method of veryfing password during LUKS creation #1103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

fix: the method of veryfing password during LUKS creation #1103

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c44ac3
Fix the method of veryfing password during LUKS creation
Eason20000 Aug 10, 2025
7efb6eb
Merge branch 'master' into master
Eason20000 Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions lib/types/luks.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,19 +143,21 @@ in

askPassword() {
if [ -z ''${IN_DISKO_TEST+x} ]; then
set +x
promptSecret "Enter password for ${config.device}: " password
promptSecret "Enter password for ${config.device} again to be safe: " password_check
export password
[ "$password" = "$password_check" ]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably better to use exit 1 if the password don't match instead of setting the debug flags

set -x
else
set -x
export password=disko
set +x
fi
}
set +x
until askPassword; do
echo "Passwords did not match, please try again."
done
set -x
''}
cryptsetup -q luksFormat "${config.device}" ${toString config.extraFormatArgs} ${keyFileArgs}
fi
Expand Down