Skip to content

Show error when attempting to create bcachefs subvolume in place of dir #1238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
zebreus wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −6
Draft

Show error when attempting to create bcachefs subvolume in place of dir #1238

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions lib/types/bcachefs_filesystem.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,12 +203,9 @@
SUBVOL_ABS_PATH="$MNTPOINT/${subvolume.name}";
# Check if it's already a subvolume (using snapshot).
if ! bcachefs subvolume snapshot "$SUBVOL_ABS_PATH" "$TEMPDIR/" >&2 2>&1; then
# It's not a subvolume, now check if it's a directory.
if ! test -d "$SUBVOL_ABS_PATH"; then
# It's not a subvolume AND not a directory, so create it.
mkdir -p -- "$(dirname -- "$SUBVOL_ABS_PATH")";
bcachefs subvolume create "$SUBVOL_ABS_PATH";
fi
# Attempt to create the subvolume otherwise.
mkdir -p -- "$(dirname -- "$SUBVOL_ABS_PATH")";
bcachefs subvolume create "$SUBVOL_ABS_PATH";
fi;
)
'') (lib.attrValues config.subvolumes)}
Expand Down
Loading