Open
Conversation
This was causing `check` to always see the tests as new/failing, but `review` to show a diff with no changes.
Tweak the output so those cases are more easily distinguishable, especially the color used by the `+` symbol next to the test name. Exit code is now 2 if all existing tests succeeded, but some were added.
Forgetting to set `src` was triggering it.
Ideally we'd just change the function to use `{ src, ... }@Args:` so Nix
can provide an explicit error the users are accustomed to.
9c92de5 to
e37d0d8
Compare
figsoda
reviewed
Feb 24, 2026
Member
figsoda
left a comment
There was a problem hiding this comment.
Sorry for the super late review
1: I can't reproduce this error. Do you have the snapshots added to git? If this fixes the issue, maybe namaka can automatically add the snapshots to git (like nix does with flake.lock)?
Everything else lgtm, I'm happy to revert (1) and merge everything else as-is.
Co-authored-by: figsoda <figsoda@pm.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, thanks for building this and haumea, both are cool projects!
Here's a couple changes I did when getting setup. If you'd like me to split this in any way, let me know.
All changes are pretty small though.
My setup is similar to the subflake template, so it's probably worth adding automated tests for the templates as that would've probably caught this bug.
Here's an example output in the common case:



Here's a comparison of "failing and added state" which is what motivated me to change this:
I was seeing the above a lot because of 1.