Conversation
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2024-04-25-documentation-team-meeting-notes-122/44080/1 |
0d68cb4 to
c604349
Compare
|
@infinisil should we merge this? It would allow this PR to move on: NixOS/nixpkgs#305847 It also allows us to utilize doc-comments for things outside of lib where the path prefix doesn't include two dots |
infinisil
left a comment
There was a problem hiding this comment.
Hmm I don't like how this breaks rendering when the flag is specified. How about just making it so that the . is only added if the prefix is non-empty?
Just pushed a new commit, to simply allow empty prefixes. Maybe a future pr could make the seperator configurable |
|
@infinisil any open points? Otherwise could we merge this. |
infinisil
left a comment
There was a problem hiding this comment.
Looking good, sorry for the delay!
Could you do the release yourself? Note that I usually manually edit the changelog in the release to match previous releases, though in the future I'd hope to get more automation for this (see NixOS/nixpkgs-vet#46)
Requires #121 to be merged first.
This closes #119
empty prefix or catgeory is possible when this gets merged