feat: resolve let-in identifier patterns to their attrset bindings#154
Closed
Alb-O wants to merge 1 commit intonix-community:masterfrom
Closed
feat: resolve let-in identifier patterns to their attrset bindings#154Alb-O wants to merge 1 commit intonix-community:masterfrom
Alb-O wants to merge 1 commit intonix-community:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for
let ... in identifierpatterns, where the body of a let-in expression is an identifier referencing an attrset bindingMotivation
Some Nix libraries define documented functions in let blocks and return them via an identifier:
Previously, nixdoc couldn't extract documentation from these files because it only looked for attrsets directly in the let-in body, not identifier references to them.
Changes
find_let_binding()to locate an AttrpathValue binding by name in a let blockresolve_let_ident()to resolve identifiers with chained resolution support (e.g.,alias = exports; in alias)collect_entries()to check if the let-in body is an identifier and resolve it before collecting bindings