Fix sudo password prompt #573
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Suppress verbose output during fact checking loops - Quiet SSH command execution to reduce log clutter - Fix sudo detection to only apply when not running as root - Add cleanup of temporary log files 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Create separate command templates for TTY vs non-TTY scenarios - Use script-based approach for sudo commands when TTY is available - Add proper error handling and success detection for kexec operations - Capture and display remote command output for debugging - Handle connection disconnection during kexec execution 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Mic92
reviewed
Jul 29, 2025
Mic92
reviewed
Jul 29, 2025
src/nixos-anywhere.sh
Outdated
| KEXEC_SCRIPT | ||
| chmod +x /tmp/kexec-script.sh | ||
| # Run the script and let output flow naturally | ||
| ${maybeSudo} /tmp/kexec-script.sh 2>&1 | tee /tmp/kexec-output.log || true |
There was a problem hiding this comment.
insecure tempfile handling. Why do we need this file?
There was a problem hiding this comment.
@Mic92 Ah because of a potential race condition with an attacker you are right, I didn't think of that.
The output log is static because then we can get the logs from the host easily without needing to back communicate the path
Mic92
reviewed
Jul 29, 2025
Mic92
reviewed
Jul 29, 2025
Mic92
reviewed
Jul 29, 2025
Mic92
reviewed
Jul 30, 2025
Mic92
reviewed
Jul 30, 2025
Co-authored-by: Jörg Thalheim <[email protected]>
Co-authored-by: Jörg Thalheim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
the problem / bug is in the line above where we run kexec with sudo inside a setsid terminal, that sudo needs to re-prompt for the password, and doesn't have access to stdin so it fails.
My Changes
Add a
breakpointfunction, it halts execution and gives you an interactive bash shell with all the internal variables in scopeReduce log spamming by adding
set +xto for loopsMake
remoteCommandwrite a shell script that then get's called once with sudo, instead of calling sudo inside the setsid shell