feat: take into effect system-features

[Mic92]

Summary by CodeRabbit

• Refactor
  • Consolidated Nix configuration evaluation when a flake is provided, generating all settings in one step.
  • Derives system-features (including platform-specific gcc) with deduplication for cleaner configuration.
  • Automatically collects substituters and trusted-public-keys and writes them together.
  • Writes a complete nix.conf only when content is available, reducing partial or duplicate entries.
  • Behavior is applied only when a flake path is present.
  • Results in a more predictable, streamlined setup for users relying on flakes.

[coderabbitai]

Warning

Rate limit exceeded

@Mic92 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 7 minutes and 19 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 2cbfde7 and 8a49b35.

📒 Files selected for processing (1)

• src/nixos-anywhere.sh (1 hunks)

Walkthrough

Consolidates nix.conf handling under flake-provided flow: evaluates a single Nix configuration to derive system-features (including gcc arch), substituters, and trusted-public-keys; assembles them into nix.conf content; and writes once to ~/.config/nix/nix.conf only if non-empty, replacing prior per-line echo/appends.

Changes

Cohort / File(s)	Summary
Consolidated nix.conf generation under flake src/nixos-anywhere.sh	Replaced per-item extraction/appends with a single Nix evaluation producing system-features (with deduped gcc feature), substituters, and trusted-public-keys; builds nixConfContent and conditionally writes to ~/.config/nix/nix.conf when flake is set; updated control flow to gate on flake presence and avoid empty writes.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant U as User
  participant S as nixos-anywhere.sh
  participant N as Nix CLI (eval)
  participant FS as File System (~/.config/nix/nix.conf)

  U->>S: Run with --flake <path>
  S->>S: Detect flake provided
  S->>N: Evaluate flake to get settings<br/>(system-features, substituters, keys)
  N-->>S: Derived settings
  S->>S: Build nixConfContent (strings, dedupe features)
  alt nixConfContent non-empty
    S->>FS: Write nix.conf (single write)
  else empty
    S->>S: Skip write
  end

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Pre-merge checks and finishing touches and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title clearly indicates that the feature enables system-features, which is a core aspect of the changeset that consolidates system-features into nix.conf. It is concise and relates directly to a real part of the implementation without introducing unrelated noise.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🧪 Early access (Sonnet 4.5): enabled

We are currently testing the Sonnet 4.5 model, which is expected to improve code review quality. However, this model may lead to increased noise levels in the review comments. Please disable the early access features if the noise level causes any inconvenience.

Note:

• Public repositories are always opted into early access features.
• You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}