Skip to content

colorschemes/gruvbox-material: init #3608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

saygo-png
Copy link
Contributor

https://github.com/sainnhe/gruvbox-material

My favourite Neovim gruvbox.

Removes fresh deprecation in accordance with #3495 (comment)

There is a missing defaults test option colors_override which is by default set to an empty vimscript dictionary
I excluded it because I could not figure out how to make it empty in nix without errors. neither __raw = "{}" or __empty = null worked.
I tested the option with actual settings and it works fine, i just can't figure out how to make it empty for the test.

@saygo-png saygo-png force-pushed the colorschemes-gruvbox-material-init branch from 928051e to d68494d Compare August 7, 2025 17:19
Copy link
Member

@MattSturgeon MattSturgeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -23,12 +23,6 @@ let
It is recommended to use `plugins.pckr` or `plugins.lazy` instead.
'';
};
renamed.colorschemes = {
# Added 2025-08-06
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to wait a few weeks before merging, to give users chance to update and see this deprecation warning.

Some time in September should be ok?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants