Skip to content

plugins/dap: add pipe type adapter #3627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

FredeHoey
Copy link
Contributor

@FredeHoey FredeHoey commented Aug 18, 2025

These are for pipe based debuggers, that don't use stdout but rather a unix pipe. The cmake debugger is an example of this and would be configured something like this

dap = {
  adapters = {
    pipes = {
      cmake = {
        pipe = "$\{pipe}";
        executable = {
            command = "cmake";
            args = [ "--debugger" "--debugger-pipe" "$\{pipe}" "build" ];
        };
      };
    };
  };
};

@nixvim-ci nixvim-ci bot requested a review from khaneliman August 18, 2025 08:37
Copy link
Contributor

@khaneliman khaneliman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but can you reword the commit properly.

plugins/dap: add pipe type adapter

@FredeHoey FredeHoey force-pushed the feat/dap-pipes-adapter-support branch from ebd42e9 to 913d446 Compare August 18, 2025 14:34
@FredeHoey FredeHoey changed the title fix(dap): add pipe type adapter fix/dap: add pipe type adapter Aug 18, 2025
@FredeHoey
Copy link
Contributor Author

@khaneliman done :)

@khaneliman
Copy link
Contributor

@khaneliman done :)

I pasted the message to use, we use a different commit style. It also wouldn't qualify as a fix for conventional commits since it's a new feature.

@FredeHoey FredeHoey force-pushed the feat/dap-pipes-adapter-support branch from 913d446 to 4f3b721 Compare August 18, 2025 18:07
@FredeHoey FredeHoey changed the title fix/dap: add pipe type adapter plugings/dap: add pipe type adapter Aug 18, 2025
@FredeHoey FredeHoey changed the title plugings/dap: add pipe type adapter plugins/dap: add pipe type adapter Aug 18, 2025
@FredeHoey
Copy link
Contributor Author

@khaneliman Totally missed that. Sorry

@khaneliman khaneliman added this pull request to the merge queue Aug 18, 2025
Merged via the queue into nix-community:main with commit e1e4bb8 Aug 18, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants