Avoid using libc::af_alg_iv to get rid of deprecation warnings #1329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Upstream's deprecation warning is informational, it is intended to let folks know that the type is soon changing. I've addressed this as part of #1285. |
asomers
approved these changes
Nov 15, 2020
This was referenced Nov 15, 2020
Merged
|
Fixed by #1332 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rust-lang/libc#1501
Not sure if this is the best approach, or whether we should just define our own version? Though I know that's generally avoided in nix. Alternatively, we could just slap a
#[allow(deprecated)]on it and figure it out later, but I just wanted to do something because it's causing CI to fail.