Add Sctp protocol and MSG_NOTIFICATION #2562
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnaaman-dn
force-pushed
the
master
branch
5 times, most recently
from
4564793 to
1bf179e
Compare
SteveLauC
reviewed
Dec 18, 2024
Member
SteveLauC
left a comment
SteveLauC
left a comment
There was a problem hiding this comment.
Thanks for the PR, just 2 cfg nits:)
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Contributor
Author
|
Thank you @SteveLauC ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do
Sctpvariant to theSockProtocolenum, allowing the user to create SCTP sockets with eitherSockType::StreamorSockType::SeqPacket.MSG_NOTIFICATIONthroughMsgFlagsso that it won't be truncated when converting fromi32.IPPROTO_SCTPis defined in RFC-6458, but it is not supported by all OSs.I've cfg'd-out targets that failed in CI.
MSG_NOTIFICATIONis Linux-specific, as far as I can tell, but is not exposed through Android's libc, so I've limited it tolinuxand notlinux_android.Checklist:
CONTRIBUTING.md