Conversation
.rbenv-version
Outdated
Owner
There was a problem hiding this comment.
Doesn't look deprecated to me: http://edgeapi.rubyonrails.org/classes/ActionView/Helpers/AssetTagHelper.html#method-i-image_tag
What happens when you use it?
Collaborator
Author
There was a problem hiding this comment.
UndefinedMethod image_tag for <Class:…>
Owner
There was a problem hiding this comment.
Alright, use image_path rather than asset_path if possible.
Excuse this gross commit message.
Gemfile.lock
Outdated
Owner
There was a problem hiding this comment.
Do a bundle update jazz_hands. I released a Rails 4 compatible version today. It should end up with 0.5.0
Owner
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
border-radius)protected_attributesgem for Rails 3 style param security till we migrate.ActiveModel::Namechange.asset_pathinstead ofimage_tagin ERB'd sass/coffee files, as the latter seems to be deprecated.matchis no longer supported withoutvia:[*methods])whiny_nils,auto_explain_threshold)schema.rbTODO
border-radius,text-shadow)routes.rbfile changes match expectations (@nixme)