Refactor header structure to improve layout and block management in b…

[MrHinsh]

…aseof.html

Summary by CodeRabbit

• Refactor
  • Restructured template layout organisation to improve modularity and maintainability. Menu and breadcrumbs rendering have been refactored into dedicated template blocks for better control and flexibility.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

Template restructuring in baseof.html removes the outer "header" block and introduces two new internal blocks: "menu" and "breadcrumbs". The header element now renders unconditionally, with menu and breadcrumb rendering delegated to their respective blocks rather than nested within the previous header block structure.

Changes

Cohort / File(s)	Summary
Template Block Refactoring module/layouts/baseof.html	Removed enclosing "header" block; header element now always renders. Introduced "menu" block wrapping main-menu logic and "breadcrumbs" block for conditional breadcrumbs rendering. Alters template composition and inheritance points for downstream consumers.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

Templates shed their outer shell,
Two new blocks now ring the bell—
Menu and breadcrumbs take their place,
Header stands with bolder face. 🎭

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: refactoring the header structure in baseof.html, which aligns with the removal of the 'header' block and introduction of 'menu' and 'breadcrumbs' blocks.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch update-to-breadcrumbs

---

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 99e14df and 679649d.

📒 Files selected for processing (1)

• module/layouts/baseof.html

🔇 Additional comments (3)

module/layouts/baseof.html (3)

142-146: Menu block structure is well-designed.

The new "menu" block cleanly encapsulates menu rendering and allows for straightforward child template customisation without affecting header semantics. The wrapping of the flex container within the block is appropriate.

---

147-152: Breadcrumbs block logic is correct.

The conditional .Kind != "home" check is preserved and sensible. The block wrapping is clean and maintains the intended behaviour whilst enabling child template customisation.

---

141-154: This flagged concern is based on a false premise: baseof.html is a newly created file, not a refactored one.

The git history shows this is a new file (mode 100644), so there's no "outer header block removal" to break existing templates. A repository-wide search confirms zero templates currently override any "header" block. The structure is sound: wrapping the menu and breadcrumbs in their own blocks gives child templates proper override points without sacrificing a working base layout.

The implementation is correct. Ship it.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

This PR refactors the header structure in the baseof.html template to improve flexibility and block management. The main change moves the <header> HTML element outside of the template block definition and splits the monolithic "header" block into two separate blocks: "menu" and "breadcrumbs".

Key Changes:

• Split single "header" block into two separate blocks ("menu" and "breadcrumbs") for more granular template overriding
• Moved <header> HTML tag outside of block definition, making it always present in the DOM
• Maintained existing conditional logic for breadcrumbs display on non-home pages

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.