Fix spacing in guide version dropdown for better readability #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR improves the guide version dropdown by adding fallback values for internationalization keys and enhancing visual formatting with better spacing.
- Added
defaultfunction to provide fallback values ("latest" and "current") for i18n keys when translations are unavailable - Replaced inline parentheses with non-breaking space (
) before parentheses for improved visual spacing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the
guide-version-select.htmlfile to improve the handling of default values for internationalised strings and ensure consistent formatting in the version dropdown.Improvements to internationalisation and formatting:
defaultfunction to provide fallback values for thei18nkeysguide_version_latestandguide_version_current, ensuring proper defaults ("latest" and "current") are displayed when translations are unavailable. ([module/layouts/_partials/components/guide/guide-version-select.htmlL15-R38](https://github.com/nkdAgility/HugoGuides/pull/5/files#diff-c404c24e2469819d871a8b512b23fec7c8517a971c91017d8f568f621135d913L15-R38)) ) before the parentheses for better visual spacing and formatting consistency in the version dropdown and version display. ([module/layouts/_partials/components/guide/guide-version-select.htmlL15-R38](https://github.com/nkdAgility/HugoGuides/pull/5/files#diff-c404c24e2469819d871a8b512b23fec7c8517a971c91017d8f568f621135d913L15-R38))