New i18n bits #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request introduces internationalization (i18n) support for the historical version notice in guide layouts, replacing hardcoded English text with translatable strings. The changes enable multi-language support for version notices and include a minor formatting improvement.
- Replaces hardcoded version notice text with i18n translation keys
- Adds English and Minion language translations for version notice components
- Improves spacing in guide version display with non-breaking space
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
module/layouts/_partials/components/guide/guide-version-notice.html |
Replaces hardcoded text with i18n function calls for version notice |
site/i18n/en.yaml |
Adds English translations for version notice components |
site/i18n/min.yaml |
Adds Minion language translations for version notice components |
module/layouts/_partials/components/guide/render-guide.html |
Adds non-breaking space after version label for improved formatting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces internationalization (i18n) for the historical version notice in the guide layout. The changes replace hardcoded text with translatable strings and add corresponding translations for English and Minion languages. Additionally, a minor formatting adjustment was made in the guide version display.
Internationalization of Historical Version Notice:
module/layouts/_partials/components/guide/guide-version-notice.html: Replaced hardcoded historical version notice text with i18n strings, including title, main text, link, and suffix.site/i18n/en.yaml: Added English translations for the historical version notice title, text, link, and suffix.site/i18n/min.yaml: Added Minion-language translations for the historical version notice title, text, link, and suffix.Minor Formatting Adjustment:
module/layouts/_partials/components/guide/render-guide.html: Added a non-breaking space ( ) after the guide version label for improved spacing.