Skip to content

Fix populate closed date in work item #2673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MrHinsh merged 2 commits into from
Apr 10, 2025
Merged

Fix populate closed date in work item #2673

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
00a2e81
Update TfsWorkItemMigrationProcessor.cs
kaflake Apr 2, 2025
e7076cf
Do not crash on CheckClosedDateIsValid if source has no closedDate
kaflake Apr 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions src/MigrationTools.Clients.TfsObjectModel/Processors/TfsWorkItemMigrationProcessor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,10 +417,6 @@ private void PopulateWorkItem(WorkItemData oldWorkItemData, WorkItemData newWork
}

newWorkItem.Title = oldWorkItem.Title;
if (newWorkItem.Fields.Contains("Microsoft.VSTS.Common.ClosedDate") && newWorkItem.Fields["Microsoft.VSTS.Common.ClosedDate"].IsEditable)
{
newWorkItem.Fields["Microsoft.VSTS.Common.ClosedDate"].Value = oldWorkItem.Fields["Microsoft.VSTS.Common.ClosedDate"].Value;
}
newWorkItem.State = oldWorkItem.State;
try
{
Expand Down Expand Up @@ -905,7 +901,17 @@ private void CheckClosedDateIsValid(WorkItemData sourceWorkItem, WorkItemData ta
if (targetWorkItem.ToWorkItem().Fields[closedDateField].Value == null && (targetWorkItem.ToWorkItem().Fields["System.State"].Value.ToString() == "Closed" || targetWorkItem.ToWorkItem().Fields["System.State"].Value.ToString() == "Done"))
{
Log.LogWarning("The field {closedDateField} is set to Null and will revert to the current date on save! ", closedDateField);
Log.LogWarning("Source Closed Date [#{sourceId}][Rev{sourceRev}]: {sourceClosedDate} ", sourceWorkItem.ToWorkItem().Id, sourceWorkItem.ToWorkItem().Rev, sourceWorkItem.ToWorkItem().Fields[closedDateField].Value);
if (sourceWorkItem.ToWorkItem().Fields.Contains(closedDateField))
{
Log.LogWarning("Source Closed Date [#{sourceId}][Rev{sourceRev}]: {sourceClosedDate} ",
sourceWorkItem.ToWorkItem().Id, sourceWorkItem.ToWorkItem().Rev,
sourceWorkItem.ToWorkItem().Fields[closedDateField].Value);
}
else
{
Log.LogWarning("Source Closed Date [#{sourceId}][Rev{sourceRev}] is not Available ",
sourceWorkItem.ToWorkItem().Id, sourceWorkItem.ToWorkItem().Rev);
}
}
if (!sourceWorkItem.ToWorkItem().Fields.Contains(closedDateField))
{
Expand Down
Loading