Conversation
Previously, the `FieldToFieldMap` class assigned values to the target field and logged a debug message regardless of whether the value was empty. This commit introduces a conditional check to handle empty values more explicitly. If the value is not empty, it is assigned to the target field, and a debug message is logged for a successful mapping. If the value is empty, the assignment is skipped, and a debug message is logged to indicate the skipped mapping. This change improves clarity, logging, and handling of empty values during field mapping.
Enhanced error logging in `TfsEmbededImagesTool.cs` to include detailed information about non-404 HTTP failures, such as status codes and reason phrases. Updated `_httpClientHandler` in `EmbededImagesRepairEnricherBase.cs` to enable automatic redirection by setting `AllowAutoRedirect` to `true`. Added debug logging for non-successful HTTP responses during file downloads, including details like URL, status code, reason phrase, and `Location` header. Made minor formatting adjustments to improve code readability.
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://blue-river-093197403-2999.westeurope.5.azurestaticapps.net |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to error handling and logging for image download and field mapping operations in the migration tools. The most notable changes are enhanced diagnostics for failed image downloads and field value mappings, and a modification to HTTP client configuration to allow redirects.
Error handling and diagnostics improvements:
TfsEmbededImagesTool.cs, including HTTP status codes and reason phrases for non-404 errors.EmbededImagesRepairEnricherBase.csby logging failed HTTP responses, including status codes, reason phrases, and location headers.Field mapping logic:
FieldToFieldMap.csto log when a field mapping is skipped due to an empty value, providing clearer diagnostics for mapping operations.HTTP client configuration:
EmbededImagesRepairEnricherBase.csto allow automatic redirects, improving compatibility with redirected image URLs.