Skip to content

feat: add changeset check workflow#461

Merged
matijs merged 1 commit intomainfrom
feat/changeset-check
Mar 14, 2025
Merged

feat: add changeset check workflow#461
matijs merged 1 commit intomainfrom
feat/changeset-check

Conversation

@matijs
Copy link
Copy Markdown
Contributor

@matijs matijs commented Mar 12, 2025 •
edited
Loading

Ik weet niet of .github/workflows/changeset.yml de juiste plek is… het kan ook gewoon een job worden binnen .github/workflows/continuous-integration.yml

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 12, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: ac7db5e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 12, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
candidate ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 14, 2025 8:30am
candidate-storybook-non-conforming ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 14, 2025 8:30am
candidate-storybook-test ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 14, 2025 8:30am
evil-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 14, 2025 8:30am

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 12, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (a13d668) to head (ac7db5e).
Report is 10 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main      #461   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           32        32           
  Lines          261       277   +16     
  Branches        36        36           
=========================================
+ Hits           261       277   +16

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@matijs matijs force-pushed the feat/changeset-check branch from 4a3ce9f to bec4028 Compare March 12, 2025 20:26
@matijs matijs force-pushed the feat/changeset-check branch from bec4028 to b3466b9 Compare March 12, 2025 20:47
@matijs matijs force-pushed the feat/changeset-check branch 2 times, most recently from 62ecfee to 814665e Compare March 12, 2025 20:50
@matijs matijs force-pushed the feat/changeset-check branch from 814665e to 4911c40 Compare March 12, 2025 20:52
@matijs matijs force-pushed the feat/changeset-check branch from b34e118 to 8ad77a0 Compare March 12, 2025 21:05
@matijs matijs force-pushed the feat/changeset-check branch from 8ad77a0 to d07fdb1 Compare March 12, 2025 21:07
@matijs matijs force-pushed the feat/changeset-check branch from d07fdb1 to 9f651df Compare March 12, 2025 21:09
@nl-design-system nl-design-system deleted a comment from sonarqubecloud bot Mar 12, 2025
@matijs matijs requested a review from eslook March 12, 2025 21:11
@matijs matijs linked an issue Mar 12, 2025 that may be closed by this pull request
GitHub App in plaats van Changeset bot #450
Closed
3 tasks
@matijs matijs force-pushed the feat/changeset-check branch from 9f651df to cea99cb Compare March 13, 2025 14:39
@matijs matijs changed the title Feat/changeset check feat: add changeset check workflow Mar 13, 2025
eslook
eslook previously approved these changes Mar 13, 2025
View reviewed changes
@matijs
feat: check the changeset status
ac7db5e 
Check if a changeset is needed and if so, leave a comment on the PR

- Add .github/workflows/changeset-status.yml
- Add package.json#scripts.changeset to add a changeset
- Add package.json#scripts.changeset:status to check if a changeset is needed
- Rename package.json#scripts.publish:changeset -> changeset:publish to
  align with the other scripts
@matijs matijs dismissed stale reviews from mennovanslooten and eslook via ac7db5e March 14, 2025 08:25
@matijs matijs force-pushed the feat/changeset-check branch from cea99cb to ac7db5e Compare March 14, 2025 08:25
@matijs matijs enabled auto-merge (rebase) March 14, 2025 08:25
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Mar 14, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@matijs matijs merged commit 0bb6b4f into main Mar 14, 2025
8 of 11 checks passed
@matijs matijs deleted the feat/changeset-check branch March 14, 2025 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eslook eslook eslook approved these changes

@Robbert Robbert Awaiting requested review from Robbert

@mennovanslooten mennovanslooten Awaiting requested review from mennovanslooten

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

GitHub App in plaats van Changeset bot

4 participants

@matijs @codecov-commenter @mennovanslooten @eslook