chore(138): improve unit testing #139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
bartveneman
reviewed
Dec 23, 2025
packages/editor/src/components/toolbar/shortcuts-dialog/index.ts
Outdated
Show resolved
Hide resolved
hilhorstt
force-pushed
the
chore/improve-unit-testing
branch
from
6b45fd8 to
150bfe6
Compare
hilhorstt
force-pushed
the
chore/improve-unit-testing
branch
from
150bfe6 to
3f6a2d3
Compare
hilhorstt
force-pushed
the
chore/improve-unit-testing
branch
from
e52addb to
e725074
Compare
hilhorstt
force-pushed
the
chore/improve-unit-testing
branch
from
9ab2091 to
9c2673d
Compare
hilhorstt
force-pushed
the
chore/improve-unit-testing
branch
from
9c2673d to
2dba465
Compare
jurgenbelien
reviewed
Jan 6, 2026
packages/editor/src/components/validations/drawer/validation-list-item/index.ts
Outdated
Show resolved
Hide resolved
packages/editor/src/components/validations/drawer/validation-list-item/index.ts
Outdated
Show resolved
Hide resolved
ermenm
reviewed
Jan 7, 2026
hilhorstt
force-pushed
the
chore/improve-unit-testing
branch
from
b9aaa38 to
c8a02b6
Compare
|
jurgenbelien
approved these changes
Jan 8, 2026
bartveneman
reviewed
Jan 8, 2026
| <div class="clippy-dialog__list-item-actions"> | ||
| <utrecht-button disabled="true">Negeren</utrecht-button> | ||
| <utrecht-button appearance="secondary-action-button" @click=${this.#focusNode}>Aanpassen</utrecht-button> | ||
| <button class="nl-button nl-button--disabled" disabled>Negeren</button> |
There was a problem hiding this comment.
Volgens mij stellen de NLDS docs voor om aria-disabled te gebruiken om button wel focusable te houden: https://nl-design-system.github.io/candidate/?path=/docs/css-button--documentatie#disabled-button
| <div class="clippy-dialog__list-item-actions"> | ||
| <utrecht-button disabled="true">Negeren</utrecht-button> | ||
| <utrecht-button appearance="secondary-action-button" @click=${this.#focusNode}>Aanpassen</utrecht-button> | ||
| <button class="nl-button nl-button--disabled" disabled>Negeren</button> |
There was a problem hiding this comment.
Suggested change
| <button class="nl-button nl-button--disabled" disabled>Negeren</button> | |
| <button class="nl-button nl-button--disabled" aria-disabled="true">Negeren</button> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.