Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2988 +/- ##
=======================================
Coverage 90.73% 90.73%
=======================================
Files 201 201
Lines 1760 1760
Branches 388 382 -6
=======================================
Hits 1597 1597
- Misses 155 157 +2
+ Partials 8 6 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Marwaxhello
requested changes
Dec 2, 2025
Contributor
There was a problem hiding this comment.
Mooi, zou nog dubbel checken bij elke changed file hier en alle ongebruikte imports of elements weghalen. <br/> niet WCAG friendly maar i dont know of dat iets geks is voor een prototype anders gewoon CSS gebruiken
Sonar klaagt over alle ongebruikte imports en andere dingetjes. Als je dit fixt runt Sonar weer
.../storybook-react/src/stories/prototype-src/accordionteksten/trouwen/BelangrijkAchternaam.tsx
Outdated
Show resolved
Hide resolved
.../storybook-react/src/stories/prototype-src/accordionteksten/trouwen/BelangrijkAchternaam.tsx
Show resolved
Hide resolved
...s/storybook-react/src/stories/prototype-src/accordionteksten/trouwen/BelangrijkAnnuleren.tsx
Outdated
Show resolved
Hide resolved
...k-react/src/stories/prototype-src/accordionteksten/trouwen/BelangrijkGemeenschapGoederen.tsx
Outdated
Show resolved
Hide resolved
...torybook-react/src/stories/prototype-src/accordionteksten/trouwen/MogelijkhedenCeremonie.tsx
Outdated
Show resolved
Hide resolved
...torybook-react/src/stories/prototype-src/accordionteksten/trouwen/MogelijkhedenEenvoudig.tsx
Outdated
Show resolved
Hide resolved
packages/storybook-react/src/stories/prototype-src/accordionteksten/trouwen/RegelenMelden.tsx
Outdated
Show resolved
Hide resolved
packages/storybook-react/src/stories/prototype-src/webpaginablokken/HulpEnContactTrouwen.tsx
Show resolved
Hide resolved
packages/storybook-react/src/stories/prototype-src/webpaginablokken/HulpEnContactTrouwen.tsx
Show resolved
Hide resolved
packages/storybook-react/src/stories/prototype-trouwen-webteksten/FormPage1.stories.tsx
Outdated
Show resolved
Hide resolved
Marwaxhello
requested changes
Dec 3, 2025
Contributor
Marwaxhello
left a comment
Marwaxhello
left a comment
There was a problem hiding this comment.
Sonar klaagt nog over een paar imports die ongebruik zijn en weg moeten
https://github.com/nl-design-system/utrecht/pull/2988/checks?check_run_id=56940485684
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prototype voor het testen van de webteksten
Omdat het een prototype is heb ik geen changelog bijgehouden