Skip to content

Comments

Feat/card as link update#3027

Open
pixelgitter wants to merge 54 commits intomainfrom
feat/card-as-link-update
Open

Feat/card as link update#3027
pixelgitter wants to merge 54 commits intomainfrom
feat/card-as-link-update

Conversation

@pixelgitter
Copy link
Contributor

Hoi Bryan, hier een PR met de volgende changes:

  1. Een arrow toegevoegd, gekoppeld met NLDS (geeft wel een warning ;))
  2. Hover aangepast in overleg met @Ollie-nl en @JeroenduC
  3. Aspect ratio als optie verwerkt
  4. Achtergrondkleur keuze als optie verwerkt
  5. Titels zijn zwart

@pixelgitter pixelgitter requested a review from bddjong January 21, 2026 15:48
@vercel
Copy link

vercel bot commented Jan 21, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
utrecht Ready Ready Preview, Comment Feb 19, 2026 4:00pm

Request Review

@codecov
Copy link

codecov bot commented Jan 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.83%. Comparing base (341a0b7) to head (d06f1d9).
⚠️ Report is 18 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3027   +/-   ##
=======================================
  Coverage   90.83%   90.83%           
=======================================
  Files         201      201           
  Lines        1768     1768           
  Branches      393      385    -8     
=======================================
  Hits         1606     1606           
- Misses        154      156    +2     
+ Partials        8        6    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

dependabot bot and others added 23 commits February 19, 2026 09:58
Bumps [changesets/action](https://github.com/changesets/action) from 1.5.3 to 1.6.0.
- [Release notes](https://github.com/changesets/action/releases)
- [Changelog](https://github.com/changesets/action/blob/main/CHANGELOG.md)
- [Commits](changesets/action@e0145ed...c48e67d)

---
updated-dependencies:
- dependency-name: changesets/action
  dependency-version: 1.6.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 5.5.1 to 5.5.2.
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md)
- [Commits](codecov/codecov-action@5a10915...671740a)

---
updated-dependencies:
- dependency-name: codecov/codecov-action
  dependency-version: 5.5.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [chromaui/action](https://github.com/chromaui/action) from 13.3.2 to 13.3.5.
- [Release notes](https://github.com/chromaui/action/releases)
- [Commits](chromaui/action@bc2d84a...07791f8)

---
updated-dependencies:
- dependency-name: chromaui/action
  dependency-version: 13.3.5
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
This becomes a problem in recent versions of @stencil/sass
It is probably better to fix this in the component itself, so that "pressed" is correctly typed as a boolean
Update Button prop typing to be stricter with string properties that
only have set strings it uses.

and a TS playground to test the enumGuard change:

https://www.typescriptlang.org/play/?#code/MYewdgzgLgBCA2ATAomArgWwOJoIYCdEYBeAKBhgB4AVAGgD4AKAN13jQFMIAuGfD3InDwAnjGoBtALoBKEvXJU6TAB680YANZgQAdzAzeKmAEsI4+Yoqt2XAHQmwwdoi6Njuc2A7MO+GQDcpKSgkLAc6Nh4hCSKNDAcKlARiOYa2npgTDacPHwCQmCi4tJyxAoU7upaOvqGMMZmFuVWMDn2js5orhDuMJ7igcGh0OIAmgAKyADKJDASAOR++CD4C7QwC7oEYI4A5uubjgBmIIcLIJoLUv3mI1BBUCIADhwwAILwflDUL2-EMEYT1eIGO4ym0xkEkiACM-FIgvc4EgAJIQT7fX6vOYIFCRHAERCMaiTGZDJFmDH4H5-OYRTAEwjE0mQoIhcCjdK1MDTKD4fa8aD8sB7OZbHb7BZsgD00uRRHpUUJ7LCMD2ET8JmAvOFooBuLRVJpr0YXMyOv2cgA-DAzfoLSKYLwAES453BWUwby6BL46KIFWjYEcRAAVV24AA8mgoM8Y3NKV9qViOKaaua+ZaYDa7TzM46Xd73UA

---

Taken over from: #2973
because of fork not having access to project tokens for UI tests and
thus can't merge.

---------

Co-authored-by: Fionn Mac an Bhaird <fionn.mac@rijksoverheid.nl>
Co-authored-by: FinnWard <33222605+FinnWard@users.noreply.github.com>
Co-authored-by: Charlotte Gieltjes <charlotte.gieltjes@rebels.io>
Addition to https://github.com/nl-design-system/utrecht/pull/3032/changes, to move the classes logic to index.scss and keep mixin.scss class-less.

No changeset needed as it's not released yet.
Bumps [anchore/sbom-action](https://github.com/anchore/sbom-action) from 0.20.9 to 0.22.1.
- [Release notes](https://github.com/anchore/sbom-action/releases)
- [Changelog](https://github.com/anchore/sbom-action/blob/main/RELEASE.md)
- [Commits](anchore/sbom-action@8e94d75...deef08a)

---
updated-dependencies:
- dependency-name: anchore/sbom-action
  dependency-version: 0.22.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Met een positieve review van Joram kan deze gemerged worden!
This file copied from the example repository
Running "pnpm prepare" will ensure husky is installed
prototype ten behoeve van het testen van een nieuwe structuur voor de
webteksten rondom trouwen
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants