-
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
docs: Add FAQ reminder to bug report template #5015
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: duvvuvenkataramana <venkataramana2048@gmail.com>
|
@nlohmann Review and merge |
nlohmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a formatting issue. Otherwise looks good.
Signed-off-by: Niels Lohmann <niels.lohmann@gmail.com>
nlohmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
|
@nlohmann Did you intentionally not merge this? |
|
It was closed before I had the chance. |
|
I didn't think it was intentional, since you approved it. |
[Describe your pull request here. Please read the text below the line and make sure you follow the checklist.]
make amalgamate.Read the Contribution Guidelines for detailed information.