Skip to content

Conversation

@pbashyal-nmdp
Copy link
Contributor

Validation of allele specific MAC codes

  • Use allele specific antigen code rules when validating MACs that cross antigen group
  • Add tests to validate allele specific antigen codes

Fixes #274

@pbashyal-nmdp pbashyal-nmdp added the bug Something isn't working label Oct 26, 2023
@pbashyal-nmdp pbashyal-nmdp self-assigned this Oct 26, 2023
Copy link
Contributor

@mmaiers-nmdp mmaiers-nmdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. If someone wants the old behavior we can make an option for it at that time.

@mmaiers-nmdp mmaiers-nmdp merged commit 84f0971 into nmdp-bioinformatics:master Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MACs with "allele specific" codes expansion

2 participants